Re: [PATCH 6/8] drm/ast: Initialize encoder and connector for VGA in helper function

Hi

Am 03.02.22 um 18:43 schrieb Javier Martinez Canillas:

On 1/11/22 13:00, Thomas Zimmermann wrote:

...

Move encoder and connector initialization into a single helper and put all related mode-setting structures into a single place. Done in preparation of moving transmitter code into separate helpers. No functional changes.

Signed-off-by: Thomas Zimmermann tzimmermann@suse.de

Reviewed-by: Javier Martinez Canillas javierm@redhat.com

[snip]

...

• encoder->possible_crtcs = 1;

[snip]

...

• encoder->possible_crtcs = drm_crtc_mask(crtc);

This is a somewhat unrelated change. It's OK because is fairly simple but I would probably still do the cleanups as separate patches.

I'll put this change into a separate patch.

Best regards Thomas

Best regards,