On Tue, Apr 27, 2021 at 8:32 PM Dave Airlie airlied@gmail.com wrote:
This is the main drm pull request for 5.13. The usual lots of work all over the place. [...]
Mikita Lipski: drm/amd/display: Add MST capability to trigger_hotplug interface
Hmm. I've already merged this, but my clang build shows that this looks buggy:
drivers/gpu/drm/amd/amdgpu/amdgpu_dm/amdgpu_dm_debugfs.c:3015:53: warning: address of 'aconnector->mst_port->mst_mgr' will always evaluate to 'true' [-Wpointer-bool-conversion] if (!(aconnector->port && &aconnector->mst_port->mst_mgr)) ~~ ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
and yeah, checking for the address of a member of a structure benign NULL doesn't really work.
I'm assuming the '&' is just a left-over cut-and-paste error or something.
Please fix after reviewing (I'm not going to blindly just remove the '&' just to silence the warning, since I don't know the code).
Linus