Hi,
On Thu, Jun 24, 2021 at 3:40 PM Linus Walleij linus.walleij@linaro.org wrote:
- spi-cpha:
- $ref: /schemas/types.yaml#/definitions/flag
- description: inherited as a SPI client node. Must be set.
- spi-cpol:
- $ref: /schemas/types.yaml#/definitions/flag
- description: inherited as a SPI client node. Must be set.
I will defer to Rob Herring (added to CC) to confirm if we really need all that stuff for spi-cpha and spi-cpol. I would have expected just:
spi-cpha: true spi-cpol: true
As I understand it, the fact that they are flags will already be validated as part of the "spi-controller.yaml" so you don't need to specify that. ...and the fact that you have them listed as "required" properties documents the fact that they must be set for your device, so I don't think you need more.
NOTE: if you're testing this using your "example" below I think you will find that you could set this to something other than just a flag and it won't yell at you. However, that's because your example has a bogus SPI controller node in it. I think if you put a real SPI controller in the example then it'll pull in the "spi-controller.yaml" bindings and magically start validating everything.
- spi-max-frequency:
- $ref: /schemas/types.yaml#/definitions/uint32
You don't need the "$ref" line here either, right? Again it'll be validated as part of the "spi-controller.yaml".
+required:
- compatible
- reg
- spi-cpha
- spi-cpol
Does "port" need to be listed as required too?