Hi Thomas, On Wed, Aug 04, 2021 at 08:30:41PM +0200, Thomas Zimmermann wrote:
Hi
Am 03.08.21 um 17:00 schrieb Sam Ravnborg:
Hi Thomas,
On Tue, Aug 03, 2021 at 11:07:01AM +0200, Thomas Zimmermann wrote:
Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it.
DRM IRQ callbacks are now being called directly or inlined.
Calls to platform_get_irq() can fail with a negative errno code. Abort initialization in this case. The DRM IRQ midlayer does not handle this case correctly.
I cannot see why the irq_enabled flag is needed here, and the changelog do not help me. What do I miss?
That's a good point. Usually, only the DRM IRQ helpers use irq_enabled in struct drm_device. It'll become legacy and we can ignore it for the driver conversion.
The exception is tilcdc, which also uses irq_enabled to make its error rollback work correctly. So I duplicated the state in the local private structure.
I'll add this explanation to the commit message.
With this added: Acked-by: Sam Ravnborg sam@ravnborg.org