Re: [PATCH v2 1/2] dt-bindings: drm/bridge: MHDP8546 bridge binding changes for HDCP

Hi Parshuram,

Thank you for the patch.

On Mon, Mar 01, 2021 at 12:22:26PM +0100, Parshuram Thombare wrote:

Add binding changes for HDCP in the MHDP8546 DPI/DP bridge binding. This binding is not used in any upstreamed DTS yet, so changing index of property 'j721e-intg' should not affect anything.

Signed-off-by: Parshuram Thombare pthombar@cadence.com

.../display/bridge/cdns,mhdp8546.yaml | 29 ++++++++++++------- 1 file changed, 19 insertions(+), 10 deletions(-)

diff --git a/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml index 63427878715e..5fdadadaac16 100644 --- a/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml +++ b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml @@ -17,21 +17,24 @@ properties: - ti,j721e-mhdp8546

reg:

• minItems: 1
• maxItems: 2

• minItems: 2

• maxItems: 3 items:

  • description: Register block of mhdptx apb registers up to PHY mapped area (AUX_CONFIG_P). The AUX and PMA registers are not part of this range, they are instead included in the associated PHY.

•  - description:
  

•      Register block of mhdptx sapb registers.
   - description:
       Register block for DSS_EDP0_INTG_CFG_VP registers in case of TI J7 SoCs.
  
  

  reg-names:

• minItems: 1
• maxItems: 2

• minItems: 2

• maxItems: 3 items:

  • const: mhdptx

•  - const: mhdptx-sapb
   - const: j721e-intg
  
  

  clocks:

@@ -53,6 +56,11 @@ properties: power-domains: maxItems: 1

• hdcp-config:
• maxItems: 1
• description:

•  HDCP version supported. Bit [0]:HDCP2.2 [1]:HDCP1.4.
  

Is this a property of the hardware, that is, are there multiple versions of this IP core covered by the same compatible string that support HDCP 1.4 only, DHCP 2.2 only or both ? Or is it a way to select what a given system will offer ?

interrupts: maxItems: 1

@@ -98,15 +106,15 @@ allOf: then: properties: reg:

•      minItems: 2
  

•      minItems: 3
     reg-names:
  

•      minItems: 2
  

•      minItems: 3
  

  else: properties: reg:

•      maxItems: 1
  

•      maxItems: 2
     reg-names:
  

•      maxItems: 1
  

•      maxItems: 2
  
  

required:

• compatible

@@ -129,8 +137,9 @@ examples:

     mhdp: dp-bridge@f0fb000000 {
         compatible = "cdns,mhdp8546";

•        reg = <0xf0 0xfb000000 0x0 0x1000000>;
  

•        reg-names = "mhdptx";
  

•        reg = <0xf0 0xfb000000 0x0 0x1000000>,
  

•              <0x0 0x4f48000 0x0 0x74>;
  

•        reg-names = "mhdptx", "mhdptx-sapb";
         clocks = <&mhdp_clock>;
         phys = <&dp_phy>;
         phy-names = "dpphy";