Re: [PATCH v3 1/9] dt-bindings: host1x: Add memory-contexts property

On 2022-02-18 11:39, Mikko Perttunen via iommu wrote:

Add schema information for the memory-contexts property used to specify context stream IDs. This uses the standard iommu-map property inside a child node.

Couldn't you simply make "iommu-map" an allowed property on the host1x node itself? From a DT perspective I'm not sure the intermediate node really fits meaningfully, and I can't see that it serves much purpose in practice either, other than perhaps defeating fw_devlink.

Robin.

Signed-off-by: Mikko Perttunen mperttunen@nvidia.com

v3:

• New patch

---

.../bindings/display/tegra/nvidia,tegra20-host1x.yaml | 10 ++++++++++ 1 file changed, 10 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-host1x.yaml b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-host1x.yaml index 4fd513efb0f7..3ac0fde54a16 100644 --- a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-host1x.yaml +++ b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-host1x.yaml @@ -144,6 +144,16 @@ allOf: reset-names: maxItems: 1

•    memory-contexts:
  

•      type: object
  

•      properties:
  

•        iommu-map:
  

•          description: Specification of stream IDs available for memory context device
  

•            use. Should be a mapping of IDs 0..n to IOMMU entries corresponding to
  

•            usable stream IDs.
  

•      required:
  

•        - iommu-map
  

•   required:
      - reg-names