On Thu, Apr 29, 2021 at 01:16:04PM -0500, Jason Ekstrand wrote:
On Thu, Apr 29, 2021 at 10:51 AM Daniel Vetter daniel@ffwll.ch wrote:
ret = set_proto_ctx_param(file_priv, pc, args);I think we should have a FIXME here of not allowing this on some future platforms because just use CTX_CREATE_EXT.
Done.
if (ret == -ENOTSUPP) {/* Some params, specifically SSEU, can only be set on fullyI think this needs a FIXME: that this only holds during the conversion? Otherwise we kinda have a bit a problem me thinks ...
I'm not sure what you mean by that.
Well I'm at least assuming that we wont have this case anymore, i.e. there's only two kinds of parameters: - those which are valid only on proto context - those which are valid on both (like priority)
This SSEU thing looks like a 3rd parameter, which is only valid on finalized context. That feels all kinds of wrong. Will it stay? If yes *ugh* and why? -Daniel