Re: [PATCH] drm: log errors in drm_gem_fb_init_with_funcs

On 2021-04-30 4:40 p.m., Simon Ser wrote:

Let the user know what went wrong in drm_gem_fb_init_with_funcs failure paths.

Signed-off-by: Simon Ser contact@emersion.fr Cc: Daniel Vetter daniel.vetter@ffwll.ch Cc: Sam Ravnborg sam@ravnborg.org Cc: Noralf Trønnes noralf@tronnes.org Cc: Andrzej Pietrasiewicz andrzej.p@collabora.com

---

drivers/gpu/drm/drm_gem_framebuffer_helper.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_gem_framebuffer_helper.c b/drivers/gpu/drm/drm_gem_framebuffer_helper.c index 109d11fb4cd4..e4a3c7eb43b2 100644 --- a/drivers/gpu/drm/drm_gem_framebuffer_helper.c +++ b/drivers/gpu/drm/drm_gem_framebuffer_helper.c @@ -155,8 +155,10 @@ int drm_gem_fb_init_with_funcs(struct drm_device *dev, int ret, i;

info = drm_get_format_info(dev, mode_cmd);

• if (!info)

• if (!info) {

• drm_dbg_kms(dev, "Failed to get FB format info\n");
  

  return -EINVAL;

• }

  for (i = 0; i < info->num_planes; i++) { unsigned int width = mode_cmd->width / (i ? info->hsub : 1);

@@ -175,6 +177,9 @@ int drm_gem_fb_init_with_funcs(struct drm_device *dev, + mode_cmd->offsets[i];

if (objs[i]->size < min_size) {

• 	drm_dbg_kms(dev,
  

• 		    "GEM object size (%u) smaller than minimum size (%u) for plane %d\n",
  

• 		    objs[i]->size, min_size, i);
  drm_gem_object_put(objs[i]);
  ret = -EINVAL;
  goto err_gem_object_put;
  
  

Reviewed-by: Michel Dänzer mdaenzer@redhat.com

I made almost the same change (except for the strings) for tracking down the issue fixed by https://patchwork.freedesktop.org/patch/431677/ (note my follow-up there!). :)