Re: [PATCH v2 1/4] fbtft: Replace custom ->reset() with generic one

On Fri, Apr 16, 2021 at 05:20:41PM +0300, Andy Shevchenko wrote:

The custom ->reset() repeats the generic one, replace it.

Note, in newer kernels the context of the function is a sleeping one, it's fine to switch over to the sleeping functions. Keeping the reset line asserted longer than 20 microseconds is also okay, it's an idling state of the hardware.

Fixes: b2ebd4be6fa1 ("staging: fbtft: add fb_agm1264k-fl driver")

What does this "fix"? A bug or just a "it shouldn't have been done this way"?

And as others pointed out, if you could put "staging: fbtft:" as a prefix here, that would be much better.

thanks,

greg k-h