On 18/06/2022 00:25, Rob Herring wrote:

On Fri, Jun 17, 2022 at 10:37:07PM +0100, Conor Dooley wrote:

...

From: Conor Dooley conor.dooley@microchip.com

ilitek,ili9341.txt was replaced by ilitek,ili9341.yaml but the txt

panel/ilitek,ili9341.yaml

*pff*, ye. Sorry for sending you on walkabout for it.

...

binding was not deleted. Do so.

Signed-off-by: Conor Dooley conor.dooley@microchip.com

.../bindings/display/ilitek,ili9341.txt | 27 ------------------- 1 file changed, 27 deletions(-) delete mode 100644 Documentation/devicetree/bindings/display/ilitek,ili9341.txt

diff --git a/Documentation/devicetree/bindings/display/ilitek,ili9341.txt b/Documentation/devicetree/bindings/display/ilitek,ili9341.txt deleted file mode 100644 index 169b32e4ee4e..000000000000 --- a/Documentation/devicetree/bindings/display/ilitek,ili9341.txt +++ /dev/null @@ -1,27 +0,0 @@ -Ilitek ILI9341 display panels

-This binding is for display panels using an Ilitek ILI9341 controller in SPI -mode.

-Required properties: -- compatible: "adafruit,yx240qv29", "ilitek,ili9341"

"adafruit,yx240qv29" is not in the schema.

I was planning to change the compatible anyway in my other series, I'll add this deletion to the start of that one.

...

-- dc-gpios: D/C pin -- reset-gpios: Reset pin

Neither is this. It is in panel-common.yaml, but 'unevaluatedProperties' needs to be used instead to allow it. Or add 'reset-gpios: true'.

...

-The node for this driver must be a child node of a SPI controller, hence -all mandatory properties described in ../spi/spi-bus.txt must be specified.

-Optional properties: -- rotation: panel rotation in degrees counter clockwise (0,90,180,270) -- backlight: phandle of the backlight device attached to the panel

-Example:

• display@0{

• compatible = "adafruit,yx240qv29", "ilitek,ili9341";
  

• reg = <0>;
  

• spi-max-frequency = <32000000>;
  

• dc-gpios = <&gpio0 9 GPIO_ACTIVE_HIGH>;
  

• reset-gpios = <&gpio0 8 GPIO_ACTIVE_HIGH>;
  

• rotation = <270>;
  

• backlight = <&backlight>;
  

• };

-- 2.36.1