there is an unexpected word "the" in the comments that need to be dropped
file: drivers/gpu/drm/display/drm_dp_helper.c line: 1600 * Doesn't account the the "MOT" bit, and instead assumes each changed to * Doesn't account the "MOT" bit, and instead assumes each
Signed-off-by: Jiang Jian jiangjian@cdjrlc.com --- drivers/gpu/drm/display/drm_dp_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/display/drm_dp_helper.c b/drivers/gpu/drm/display/drm_dp_helper.c index e7c22c2ca90c..499f75768523 100644 --- a/drivers/gpu/drm/display/drm_dp_helper.c +++ b/drivers/gpu/drm/display/drm_dp_helper.c @@ -1597,7 +1597,7 @@ static int drm_dp_aux_reply_duration(const struct drm_dp_aux_msg *msg) * Calculate the length of the i2c transfer in usec, assuming * the i2c bus speed is as specified. Gives the the "worst" * case estimate, ie. successful while as long as possible. - * Doesn't account the the "MOT" bit, and instead assumes each + * Doesn't account the "MOT" bit, and instead assumes each * message includes a START, ADDRESS and STOP. Neither does it * account for additional random variables such as clock stretching. */
Reviewed-by: Lyude Paul lyude@redhat.com
Will push to the appropriate branch in a moment
On Tue, 2022-06-21 at 21:14 +0800, Jiang Jian wrote:
there is an unexpected word "the" in the comments that need to be dropped
file: drivers/gpu/drm/display/drm_dp_helper.c line: 1600 * Doesn't account the the "MOT" bit, and instead assumes each changed to * Doesn't account the "MOT" bit, and instead assumes each
Signed-off-by: Jiang Jian jiangjian@cdjrlc.com
drivers/gpu/drm/display/drm_dp_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/display/drm_dp_helper.c b/drivers/gpu/drm/display/drm_dp_helper.c index e7c22c2ca90c..499f75768523 100644 --- a/drivers/gpu/drm/display/drm_dp_helper.c +++ b/drivers/gpu/drm/display/drm_dp_helper.c @@ -1597,7 +1597,7 @@ static int drm_dp_aux_reply_duration(const struct drm_dp_aux_msg *msg) * Calculate the length of the i2c transfer in usec, assuming * the i2c bus speed is as specified. Gives the the "worst" * case estimate, ie. successful while as long as possible.
- Doesn't account the the "MOT" bit, and instead assumes each
- Doesn't account the "MOT" bit, and instead assumes each
* message includes a START, ADDRESS and STOP. Neither does it * account for additional random variables such as clock stretching. */
Actually I hate to ask but could you resend this and the other patch that you sent and make sure that dri-devel@ is explicitly in the to: list? For some reason these patches don't seem to be coming up on patchwork
On Tue, 2022-06-21 at 13:54 -0400, Lyude Paul wrote:
Reviewed-by: Lyude Paul lyude@redhat.com
Will push to the appropriate branch in a moment
On Tue, 2022-06-21 at 21:14 +0800, Jiang Jian wrote:
there is an unexpected word "the" in the comments that need to be dropped
file: drivers/gpu/drm/display/drm_dp_helper.c line: 1600 * Doesn't account the the "MOT" bit, and instead assumes each changed to * Doesn't account the "MOT" bit, and instead assumes each
Signed-off-by: Jiang Jian jiangjian@cdjrlc.com
drivers/gpu/drm/display/drm_dp_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/display/drm_dp_helper.c b/drivers/gpu/drm/display/drm_dp_helper.c index e7c22c2ca90c..499f75768523 100644 --- a/drivers/gpu/drm/display/drm_dp_helper.c +++ b/drivers/gpu/drm/display/drm_dp_helper.c @@ -1597,7 +1597,7 @@ static int drm_dp_aux_reply_duration(const struct drm_dp_aux_msg *msg) * Calculate the length of the i2c transfer in usec, assuming * the i2c bus speed is as specified. Gives the the "worst" * case estimate, ie. successful while as long as possible.
- Doesn't account the the "MOT" bit, and instead assumes each
- Doesn't account the "MOT" bit, and instead assumes each
* message includes a START, ADDRESS and STOP. Neither does it * account for additional random variables such as clock stretching. */
I need resubmit a new patch, how can i make sure dri-devel@ is explicitly？I got to:list by the script name of get_maintainer.pl. Pls help me…
发自我的企业微信
----------Reply to Message---------- On Wed,Jun 22,2022 2:07 AM Lyude Paul <lyude@redhat.com> wrote: Actually I hate to ask but could you resend this and the other patch that you sent and make sure that dri-devel@ is explicitly in the to: list? For some reason these patches don't seem to be coming up on patchwork
On Tue, 2022-06-21 at 13:54 -0400, Lyude Paul wrote: > Reviewed-by: Lyude Paul <lyude@redhat.com> > > Will push to the appropriate branch in a moment > > On Tue, 2022-06-21 at 21:14 +0800, Jiang Jian wrote: > > there is an unexpected word "the" in the comments that need to be dropped > > > > file: drivers/gpu/drm/display/drm_dp_helper.c > > line: 1600 > > * Doesn't account the the "MOT" bit, and instead assumes each > > changed to > > * Doesn't account the "MOT" bit, and instead assumes each > > > > Signed-off-by: Jiang Jian <jiangjian@cdjrlc.com> > > --- > > drivers/gpu/drm/display/drm_dp_helper.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/display/drm_dp_helper.c > > b/drivers/gpu/drm/display/drm_dp_helper.c > > index e7c22c2ca90c..499f75768523 100644 > > --- a/drivers/gpu/drm/display/drm_dp_helper.c > > +++ b/drivers/gpu/drm/display/drm_dp_helper.c > > @@ -1597,7 +1597,7 @@ static int drm_dp_aux_reply_duration(const struct > > drm_dp_aux_msg *msg) > > * Calculate the length of the i2c transfer in usec, assuming > > * the i2c bus speed is as specified. Gives the the "worst" > > * case estimate, ie. successful while as long as possible. > > - * Doesn't account the the "MOT" bit, and instead assumes each > > + * Doesn't account the "MOT" bit, and instead assumes each > > * message includes a START, ADDRESS and STOP. Neither does it > > * account for additional random variables such as clock stretching. > > */ >
-- Cheers, Lyude Paul (she/her) Software Engineer at Red Hat
You can send it by adding email addresses to git send-email with the "--to foo@bar.net" argument. If it doesn't come up on patchwork the second try don't worry about it, I'll look and see if I can workaround it. TBH I'm not entirely sure why it didn't show up in the first place
On Wed, 2022-06-22 at 02:38 +0800, 蒋健 wrote:
I need resubmit a new patch, how can i make sure dri-devel@ is explicitly？I got to:list by the script name of get_maintainer.pl. Pls help me…
发自我的企业微信
----------Reply to Message---------- On Wed,Jun 22,2022 2:07 AM Lyude Paul lyude@redhat.com wrote: Actually I hate to ask but could you resend this and the other patch that yo u sent and make sure that dri-devel@ is explicitly in the to: list? For some reason these patches don't seem to be coming up on patchwork
On Tue, 2022-06-21 at 13:54 -0400, Lyude Paul wrote:
Reviewed-by: Lyude Paul lyude@redhat.com Will push to the appropriate branch in a moment On Tue, 2022-06-21 at 21:14 +0800, Jiang Jian wrote: > there is an unexpected word "the" in the comments that need to be droppe
d
> > file: drivers/gpu/drm/display/drm_dp_helper.c > line: 1600 > * Doesn't account the the "MOT" bit, and instead assumes each > changed to > * Doesn't account the "MOT" bit, and instead assumes each > > Signed-off-by: Jiang Jian jiangjian@cdjrlc.com > --- > drivers/gpu/drm/display/drm_dp_helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/display/drm_dp_helper.c > b/drivers/gpu/drm/display/drm_dp_helper.c > index e7c22c2ca90c..499f75768523 100644 > --- a/drivers/gpu/drm/display/drm_dp_helper.c > +++ b/drivers/gpu/drm/display/drm_dp_helper.c > @@ -1597,7 +1597,7 @@ static int drm_dp_aux_reply_duration(const struct > drm_dp_aux_msg *msg) > * Calculate the length of the i2c transfer in usec, assuming > * the i2c bus speed is as specified. Gives the the "worst" > * case estimate, ie. successful while as long as possible. > - * Doesn't account the the "MOT" bit, and instead assumes each > + * Doesn't account the "MOT" bit, and instead assumes each > * message includes a START, ADDRESS and STOP. Neither does it > * account for additional random variables such as clock stretching. > */
-- Cheers, Lyude Paul (she/her) Software Engineer at Red Hat
dri-devel@lists.freedesktop.org
-
Jiang Jian -
Lyude Paul -
蒋健