This series adds support for the eDP PHY on Qualcomm SC7280 platform. The changes are dependent on v4 of the new eDP PHY driver introduced by Bjorn: https://patchwork.kernel.org/project/linux-arm-msm/list/?series=575135
Sankeerth Billakanti (3): dt-bindings: phy: Add eDP PHY compatible for sc7280 phy: qcom: Add support for eDP PHY on sc7280 phy: qcom: Program SSC only if supported by sink
Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 4 +++- drivers/phy/qualcomm/phy-qcom-edp.c | 9 ++++++--- 2 files changed, 9 insertions(+), 4 deletions(-)
Add compatible string for the supported eDP PHY on sc7280 platform.
Signed-off-by: Sankeerth Billakanti quic_sbillaka@quicinc.com --- Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml index 9076e19..a5850ff 100644 --- a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml @@ -16,7 +16,9 @@ description:
properties: compatible: - const: qcom,sc8180x-edp-phy + enum: + - qcom,sc7280-edp-phy + - qcom,sc8180x-edp-phy
reg: items:
Quoting Sankeerth Billakanti (2021-11-15 23:07:36)
Add compatible string for the supported eDP PHY on sc7280 platform.
Signed-off-by: Sankeerth Billakanti quic_sbillaka@quicinc.com
Reviewed-by: Stephen Boyd swboyd@chromium.org
The sc7280 platform supports native eDP controller and PHY. This change will add support for the eDP PHY on sc7280.
Signed-off-by: Sankeerth Billakanti quic_sbillaka@quicinc.com --- drivers/phy/qualcomm/phy-qcom-edp.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c b/drivers/phy/qualcomm/phy-qcom-edp.c index 17d5653..6d9404d 100644 --- a/drivers/phy/qualcomm/phy-qcom-edp.c +++ b/drivers/phy/qualcomm/phy-qcom-edp.c @@ -654,6 +654,7 @@ static int qcom_edp_phy_probe(struct platform_device *pdev) }
static const struct of_device_id qcom_edp_phy_match_table[] = { + { .compatible = "qcom,sc7280-edp-phy" }, { .compatible = "qcom,sc8180x-edp-phy" }, { } };
Quoting Sankeerth Billakanti (2021-11-15 23:07:37)
The sc7280 platform supports native eDP controller and PHY. This change will add support for the eDP PHY on sc7280.
Signed-off-by: Sankeerth Billakanti quic_sbillaka@quicinc.com
Reviewed-by: Stephen Boyd swboyd@chromium.org
Some legacy eDP sinks may not support SSC. The support for SSC is indicated through an opts flag from the controller driver. This change will enable SSC only if the sink supports it.
Signed-off-by: Sankeerth Billakanti quic_sbillaka@quicinc.com --- drivers/phy/qualcomm/phy-qcom-edp.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c b/drivers/phy/qualcomm/phy-qcom-edp.c index 6d9404d..06ba609 100644 --- a/drivers/phy/qualcomm/phy-qcom-edp.c +++ b/drivers/phy/qualcomm/phy-qcom-edp.c @@ -335,9 +335,11 @@ static int qcom_edp_phy_power_on(struct phy *phy) writel(0x00, edp->tx0 + TXn_LANE_MODE_1); writel(0x00, edp->tx1 + TXn_LANE_MODE_1);
- ret = qcom_edp_configure_ssc(edp); - if (ret) - return ret; + if (edp->dp_opts.ssc) { + ret = qcom_edp_configure_ssc(edp); + if (ret) + return ret; + }
ret = qcom_edp_configure_pll(edp); if (ret)
Quoting Sankeerth Billakanti (2021-11-15 23:07:38)
Some legacy eDP sinks may not support SSC. The support for SSC is indicated through an opts flag from the controller driver. This change will enable SSC only if the sink supports it.
Signed-off-by: Sankeerth Billakanti quic_sbillaka@quicinc.com
I suppose as long as the existing user has already chosen to set the opts in the controller driver then this is fine.
Reviewed-by: Stephen Boyd swboyd@chromium.org
Quoting Sankeerth Billakanti (2021-11-15 23:07:35)
This series adds support for the eDP PHY on Qualcomm SC7280 platform. The changes are dependent on v4 of the new eDP PHY driver introduced by Bjorn: https://patchwork.kernel.org/project/linux-arm-msm/list/?series=575135
Sankeerth Billakanti (3): dt-bindings: phy: Add eDP PHY compatible for sc7280 phy: qcom: Add support for eDP PHY on sc7280 phy: qcom: Program SSC only if supported by sink
This series was sent to the wrong maintainers. It's in the phy framework, not the drm framework. Please use scripts/get_maintainers.pl to find the right email addresses and send this series again.
Hi,
On Wed, Feb 2, 2022 at 1:54 PM Stephen Boyd swboyd@chromium.org wrote:
Quoting Sankeerth Billakanti (2021-11-15 23:07:35)
This series adds support for the eDP PHY on Qualcomm SC7280 platform. The changes are dependent on v4 of the new eDP PHY driver introduced by Bjorn: https://patchwork.kernel.org/project/linux-arm-msm/list/?series=575135
Sankeerth Billakanti (3): dt-bindings: phy: Add eDP PHY compatible for sc7280 phy: qcom: Add support for eDP PHY on sc7280 phy: qcom: Program SSC only if supported by sink
This series was sent to the wrong maintainers. It's in the phy framework, not the drm framework. Please use scripts/get_maintainers.pl to find the right email addresses and send this series again.
To help out, I've re-posted this myself, hopefully getting all the correct maintainers.
https://lore.kernel.org/r/20220208001704.367069-1-dianders@chromium.org
dri-devel@lists.freedesktop.org