[Clipart] uploader problems

[Nicu Buculei]

Jonadab the Unsightly One wrote:
> Nicu Buculei <nicu at apsro.com> writes:
>>i believe this file was damaged by the uploader, i can't open it in
>>Inkscape: http://openclipart.org/incoming//red_flower_03.svg (unless i
>>clean it before in a text editor)
> 
> 
> Indeed.  I can't tell for sure, but this looks like it could
> potentially represent a bug in CGI::Lite or else the file could have
> been corrupted before it was uploaded.  Or it could be a bug in the
> way the client's browser handles file upload, but that seems the least
> likely of the three.
> 
> Given that the file included many carriage returns, but not at the end
> of every line, just some lines, it seems most likely that the file was
> already corrupted before upload.  But it's hard to be sure, and that
> thing at the end did look like a separator, such as the kind used in
> MIME and also in CGI file uploads.  Hmmmm...  We should watch for
> this, to see if it happens repeatedly.

this was happened before, see 
http://www.openclipart.org/incoming//failed/flourish_three_lower_left_corner_01.svg 
and 
http://www.openclipart.org/incoming//failed/flourish_three_upper_right_corner_01.svg


>>the uploader has accepted this file as SVG, but the file is PNG with
>>.svg extension: http://openclipart.org/incoming//red_flower_02.svg
> 
> 
> Currently, the uploader does not make any attempt to second-guess what
> filetype the user says a file is; it just takes the user's word for
> it.  Also, until recently, SVG was the default.  I anticipated this
> problem and have changed it so that the default is to not specify the
> filetype, in which case the upload script complains and makes you
> specify a filetype.  So it's harder to just forget that now.  However,
> it's still easy enough to pick the wrong one -- or to pick the
> filetype for the file you _intended_ to upload and then grab the wrong
> one for the upload.  

SVG::Metadata not return an error when writing XML metadata in a not XML 
file?

-- 
nicu