can someone review this patch? (a part is for slackware, the other part is custom user)

Olivier Andrieu oliv__a at users.sourceforge.net
Thu Aug 5 01:57:35 PDT 2004


Hi,

 Kristof Vansant [Thu, 05 Aug 2004]:
 > http://freedesktop.org/bugzilla/show_bug.cgi?id=981
 > 
 > the patch is: 
 > -a slackware init script (distro gets detected)
 > -you can specify as which user the daemon will be run 
 > ./configure --with-dbus-user=foo (default = messagebus)

,----
| stop() {
|     echo "Stopping system message bus"
| 
|     ## we don't want to kill all the per-user $processname, we want
|     ## to use the pid file *only*; because we use the fake nonexistent 
|     ## program name "$servicename" that should be safe-ish
|     killall dbus-daemon-1
`----

You should really do what the comment says : just kill the system bus
(using the .pid file) and not every single dbus process running on the
host. You should remove the .pid file also.

-- 
   Olivier


More information about the dbus mailing list