Plattforms without abstract sockets

Havoc Pennington hp@redhat.com
Sun, 29 Feb 2004 18:11:36 -0500


On Sun, 2004-02-29 at 10:57, Benedikt Meurer wrote:
> Hello,
> 
> The configure script defines HAVE_ABSTRACT_SOCKETS to either 0 or 1 depending 
> on whether abstracts sockets are available or not. In either case, 
> HAVE_ABSTRACT_SOCKETS will be defined in config.h. But the C files (actually 
> dbus-server.c and dbus-sysdeps.c) test whether HAVE_ABSTRACT_SOCKETS is 
> defined, not if its value is 0 or 1. Therefore either configure.in has to be 
> changed to defined HAVE_ABSTRACT_SOCKETS only for plattforms with abstract 
> sockets or the C files should be changed to use something like  #if 
> defined(HAVE_ABSTRACT_SOCKETS) && HAVE_ABSTRACT_SOCKETS.
> 

Indeed, this should be made consistent with the other configure checks
(however they are set up). Either #if HAVE_ABSTRACT_SOCKETS or don't
define at all when it would be 0.

Havoc