Ping test case and fixup patch

Havoc Pennington hp at redhat.com
Wed Sep 28 18:59:07 PDT 2005


On Wed, 2005-09-28 at 19:58 -0400, John (J5) Palmieri wrote:
> -      
> -      sent = dbus_connection_send (connection, ret, NULL);
> +     
> +      /* We assume we are being called from dispatch which 
> +       * has a lock on the connection object and that dispatch
> +       * needs to retain the lock after we send the message 
> +       */
> +      sent = _dbus_connection_send_and_unlock (connection, ret,
> NULL);
> +      CONNECTION_LOCK (connection);
> +


I would change builtin_filters() to builtin_filters_unlocked_no_update()
and then use dbus_connection_send_unlocked_no_update()
(dbus_connection_dispatch already does the update I think)

Havoc




More information about the dbus mailing list