[immodule-qt] Re: SVN is available (again)

Mon May 16 04:56:51 EEST 2005

On 5/16/05, LiuCougar <liucougar at gmail.com> wrote:
> our SVN is back:
> 
> anonymous access:
> http://svn.freedesktop.org/immqt/
> 
> developer access:
> svn+ssh://svn.freedesktop.org/svn/immqt/
> 
> Please ask the fd.o admin to move back your home dir if you can not
> login into your account in fd.o.

websvn:
http://cvs.freedesktop.org/immqt/

-- 
"People's characters are strengthened through struggle against
difficulties; they are weakened by comfort."
- Old Chinese adage

                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                 
--Boundary-00=_oDEsChmeR743H14
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline


 Hello,

 immodule for Qt as shipped in SUSE Linux 9.3 
(qt-x11-immodule-unified-qt3.3.3-20041203.diff) has a bug that causes invalid 
QEvent::KeyRelease events, as demonstrated by the attached testcase.

 The problem seems to be caused by the fact that 
QETWidget::translateKeyEventInternal() does computations only for KeyPress 
events and saves the results for later for the following KeyRelease event. 
The immodule patch however causes that function to be called twice for one X 
KeyRelease event, once in QApplication::x11ProcessEvent(), which uses and 
discards the saved results, and once more from QETWidget::translateKeyEvent() 
(called also from QApplication::x11ProcessEvent()), for which there is no 
information saved anymore and therefore it generates QKeyEvent with invalid 
data.

 The attached patch seems to fix the problem. I have no idea what 
'statefulTranslation' actually means, but that's what distinguishes the first 
call done from QApplication::x11ProcessEvent() from the second call, so I 
used it to avoid discarding the saved data prematurely.

-- 
Lubos Lunak
KDE developer
---------------------------------------------------------------------
SuSE CR, s.r.o.  e-mail: l.lunak at suse.cz , l.lunak at kde.org
Drahobejlova 27  tel: +420 2 9654 2373
190 00 Praha 9   fax: +420 2 9654 2374
Czech Republic   http://www.suse.cz/

--Boundary-00=_oDEsChmeR743H14
Content-Type: text/x-diff; charset="utf-8"; name="qapplication_x11.cpp.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename="qapplication_x11.cpp.patch"

--- src/kernel/qapplication_x11.cpp.sav	2005-06-15 15:43:02.000000000 +0200
+++ src/kernel/qapplication_x11.cpp	2005-06-15 16:26:36.000000000 +0200
@@ -5209,11 +5209,12 @@ bool QETWidget::translateKeyEventInterna
     } else {
 	key  	if ( key )
-	    if( !willRepeat ) // Take out key of dictionary only if this call.
+	    if( !willRepeat && statefulTranslation ) // Take out key of dictionary only if this call.
 		keyDict->take( keycode );
 	long s  	if ( s ) {
-	    textDict->take( keycode );
+            if( statefulTranslation )
+		textDict->take( keycode );
 	    ascii  	}
     }

--Boundary-00=_oDEsChmeR743H14
Content-Type: application/x-tgz;
  name="keyreleaseerror.tar.gz"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
	filename="keyreleaseerror.tar.gz"

H4sIAGs7sEIAA+0b+3vaOLK/4r9iNtvtGhoMhpBcSdNvCSEpW2hIoNvsXe/LGluAL34Q25BkH/e3
34wkPyA02d416fUOfSm2pHlpNJoZSa5hOr55UXrykKWMZadWw2eltqXv8Lq+tcWfsjzRqa9crdWq
20/Kul6rlp9A7UGlkmUWRkYA8MRxZp5xcRccC8LHEOhxiyHmv2tcsJHtsAfhQRO8zed75fxv6zV9
af6r+k71CZQfRJql8n8+/99+zqJ8C7EhwcgPYDizHcv2xnUQZob9R8xjgRExC4Y3cOkiNKi6Vt4x
8qCeRFDVqtpWHnyvDu8R5seZB3oN9O165UW9VoZKuVxDIr3A/wczozpIuto08LF5wNypg7SR3XSK
9abvuoZn1eGpetJtvGnloeinAmZRP6sSYnLEf4qcgk2IfN8JAWUBfxrZvhcqSrMJouzB2DSV5tlZ
Un3+XOm0kurIYdfKzw0Jvwc3BoEfdhpHfV4vTu0pg+JxBYquEZiTPbv2l218N6ezPXubXkcuC0Nj
zIoO88bRZK8MxfeG4yS//xYyFA9OBudvj88PWvvvjkSt/7px2joQ74PGfqeFTe96vePTAY1PiPy1
CIwzEAvMtc8rKLyltN82e43Ba677dmkWBiXHHpYuo2rJvQinzAxLFhsZMyfCbi0GsT3TmVk47DYa
4+CgfZqPm5RO++2b7NSnU4td+33Z9VTtv9unOlpxJ+GK7wk9Wed9Z7p+ui1bnEuUxDlj1/yh6/jr
Ko3TxPzQ/ZmXoXLaeIvkBd/ucRMSvpL80PZKrm8q79qr+2a2qfBlJvr42lYGMZ89IDdbNEfK0V/b
vXi4v9pTKL4YKc3j3s+yzcQW0XB+2O60iAlV8qIJuUHSBMUAJ6M/aHQ6C7C8kk+6sjhUySsHLYGA
zYFL7Po/d8Us7IHjQTEccRBC5CCWHaBKfmpJEd05F/H1G4I4b521+wO0jIiFEZlH9w3H44AXiIn2
nrqE41k0nUWAzei//OBGUY73f2w1B30ppVZKYQ/Rd6CjeN1qHLROyQ6lx5oo/eN3p81WpsmcTuGD
ksu5hu1RJaaaQvhpv68cHp92uWHjXB60mp34vd3tiff+aVOYAI7BN89TLkSYehbafeUAVZATxpR6
VW4MuKxOj1qDpAcV2x9IxSqyL8VTlJEdhOjYccEmemijV7dNO4JgxhWi9d8dHrbPWv06aCbgyPjw
NRPfzetr0JoIgi2aX1dyOOtnZ2goJvA3vrTy+C7XMI8IT3+Apy8Jx/x0lOvrT8ZpfjqXGKMZI9wF
Hqttn4JvrDPUZz0NfU9Vofm8oiSvGEyfqrE9EGlpQvIVJz0PQFLQQqHGjhSCOMdEVqPxt+Zxt8fR
yIUpCpqPMUTRKDgLa8sr6EGStqwksWVycQmyjoKoYFqpAwoDk5wTPHuGbSLWI3Q84HrGLAHuctkl
7rY00/dGi3D0xH+XEdJwSA13ZxScDIn5w32QimWTwSNk7C1Ai9xpSYCIAaVODYrFqREwLwpJb8IN
kIqkk6BXvrjphRZlPkusRNS43n5BTp7hsmzvL4IXzmQ+lo9cdlYOct0LnXmpcPSN+dVESym0Nv4V
NIEQO2By4VlwbhemwwwPDb6YhUus6VZ7bD1kPgJToRRJvmPyJN/EA2IGq+hzw13qKPwTTD9gUNDo
oaTrqz8bFtEiAiOwaYXRNEoWq+mnSyRZfOSIm636rYwR16v0rPWsh0/8vyL8OA5G+vtsV8Yv15e8
d5IvT2ABELvqIJZWSim31EAGvBQMUhft4S4KXbZiixd0JjgfXrb2pTc667KySM+QTuoD8Lhn/79D
hz20/69WdrarOt//b+3srPf/j1FKhc9YlEIBFPFo+tObwB5PIlDRh+gvXlSKuHkvwyDwHSdi5gQa
fQ2ggRszDhZCwFDDc2ZpksJgYofAoyU+MehF4I9wCw3s2sCEkAEGz3FguPyg4SRCWhxB9hKBGMA1
bmDIACfQ2gRy04E9nNEJBO3HXd+yRzZWruxo4mNq7tiuHRm0SZeCfMZCyX28EdyI/epG2vbyMrJd
FmiTV9m2KTr56Fbr0I5cY0qNSqmEf6hx9LbBzIzooAH/DMcfgwjeV7Y1ZhFEEyMiNXAAThOB4GTA
eRIVpcGxmoRUr2cqKpy8FzQKIv3YxKCI7MCc4OIp8KifV2jTU48hVYghZe9vvJ8GiOk+Z1qvm7OA
YKii5ndzORwGMZHNHJhjxcJyURHdY1dSbhVHhdOOyIhrBsyIWDo0rk1OAKX1cMelLlLahH776G2j
oxIgTr6az2NT53iQaUDSt0UoviKvgeRqZNNScoaGA6E9Js5szoIbqEHIkLMVcgohi96wGwrxaOoh
GhjKHsxYzOA/WYklQaEE9kjow7E9vm6QJ+2l4ILd4ALDvCRkJBvljzg7tKKoZw/KsYRtD/enXYZr
wWp5lI1bn1PKPxRl7tsWLNgZSnAqRGuRZGhrqCb+CoXUcC4P2HA2VmFjCRy+s/BvYxNY8RV2qXn+
ZoeNWeSfsikahMrncCVr18fl0KPpiFl3qeUWc3uk2uHAn3ZQdw4ZhZIzcU960fNDVB7ym/ohsnkO
Jz0fDUUdM99lUYDSaBFhjUiIIozQHbGjFX13ytf15+zTxFNyLuKoJNjY8YeG0+PiFSERWjAUjmMw
YXIx1euJ3ceGbJNjNpk9Fye23LhCx4+EvxAE3k+YB1dMGBs5aLlf52sd2y3f+z6CK4NWNPLK8EBC
EPnknYmOiZbK3fKNSxm3EQp2aLeYYYPvwYK7IOa3NYYy8G7pn/i44BlEyw4oEuaM4eATXAOJ83EH
MQLVQKPrGuEFn4PZ1EJvJKoChDkhi9tVMQUrhpCQlhKLMfiOdR7Ljo/de71pIlSCqrm2NyPO8I0g
kjYoud9/T+EwEAYZKFnNw2/k5gQOYNSldpjgNGEU8MbMUnK3dEAyLOohJ5SQdsSi/vERdfDwF9t/
L6lAIWP+OMiULbbnAhbNAk8QFkgYNzilJGDwPt6kodHsB7NwQlbj+MFR4M+muDwxs2BjfPcsNZll
KzCuZEh8xpGTpQTtETdvEXKRRRQYXhgHwSuegCzognBoh8QMixxxZpz5VXrIotI8CO6Cm4utsbXs
88QAhq6Ka/hXloo+dDVMpxw5SBG2kFBGTGWFvrJ6GrKxjVHr2dDdvF+LehwXadye7xUzjATEIm6P
eRlM5ePazqAxmprdOHZx3eAwb3m3ZEpEKmWhSLY3BgN0DN/X9APh5YwCoun7gWV7lEWENzg1OFDb
IzI0swaYjBSDBAT4JvmooT2mB0aA0MZ4yRNRJjkF32MHo2zMIiJDUo8Yo4i/lJNqqx1ZZujJhBSk
DuRU8xqmIsY8WUQL7Sx6b3uWf6VCEfOUTf7Dh7ypi7RFzvcpuj+Yox+RiHObXU19TG/S1AcscjPd
9lsV5hqmk9GEAu1cmzBK3lMbS1n/FBNBKEcEwOegJshFK1+qbCpogXMKg3FvTE90AyXskB2aiK+N
IMCcfhqFWWNYVIRsCvyIXAxUywU148u+0yvFKrFc8IKlSjKMKOQmScxCFbY2AXcvm6g9QDXiG9Lj
1fJmpbw0dD5vvjdn1z3fuRlTlofUloAw44jQuaj5Pz0AdUHSol7LF7bvkFaX4tELbMXC6p9FWNpw
8WgJ9l55F+yXegV/nz+nAKHkMpQ7mISiOFuc+9Y2Pohy7tbUQBIBPsJ2dWDAITdipz/0fQeG2YAw
pKBGLskwL4QT7/oWsusZDosidpj4dsgE5ztR0uYYRW51lkThAn/pff2fLYvnP5ZvPgCPe85/yltb
+hP6QGhnu1rbrpXF+Y++Pv95jFIqKApuzEqFb9CeP0yNcXw5UZQnKdokch1amB8wZFJiFB+x0Kb2
Q2RHDpPLEpriCH/xJIZS7Klj3HzsVEIjhJeT4BU9X2MuhHGO39lInuK8Y9FMJ1kcuh5kLgZmfmhz
Fxo/sk4Ru+hnVoInt6h0YPOlJ+iBy6KGpoH/ADzuW//6Dv/+q4qd+vZ2hdZ/rVxZr//HKINWt9dp
DFq5Pf7RlLiayuXSC/nm8dvD9lEu93wPLmkTH3jnuBOXZ0nJ1wkpRvp5QqYt/j4Bkhur//V19bWU
JZf3IDzuWf/6Fq35xfhfWa//xynr+5//qvsf9MGObQr2dLWj0DaLFqfYcBnB2NyUly4FrMyTs4CT
RooJhiohBYjYrGT2TlAQGZi4SMl0ZA4NiQDs7UGFvthAnZnulDfO/6b/fRM2sqc5G7jzQ8gyHbyJ
3PFVdkMEg9N3rVgK2Y+TTWdTdBrBjyTibkPj5zi2F18iCUEXkRGkafDvaNWNkwha0iCKC3noxhLO
xL/KnmegAPSFJkYojV0zM+6yMK5F8sBItIiTRAn/Ne3s/lxZSqwfhMc9/r9Sru7E+V95R+f5n15Z
3/8/Sln7/8f2/yPPYiNoNDvHzTfnr5VvsUaXtUlDNhzILfLizT9dA4izTAwQpmOEoby+25W1rKev
w3Q2xMAQn1XxE/kV2/A4jJyLz+AUgVVfjhy3PgTYK9/+FGAvcef80G7FOZ080cUZQlPAqain0Ldv
zXjzR2+BskB3X+fegvzYxWoWcMUxfGFhdHfdXkM6UHvO7xQcPwozg02u+nYVqfFbIB+/0CQcQbee
ORtP7nh3M5eH6Y2hsBQoLFx2YljbpS8bmYeLgT4jSIzxS7undXngIuO/Zs7pwt8PHuJ/AN53/lPe
ruH+b6tSK+9Uaztb/Pxna/3//x6lxJ+kL30OLD9AVjTxPXzsLTTTMCds7RXWZV3WZV3WZV3WZV3W
ZV3WZV3WZV3WZV3WZV2+jvIvqykB0ABQAAA
--Boundary-00=_oDEsChmeR743H14--

