[Mesa-dev] [PATCH] glsl: fix matrix type check in ir_algebraic (miscompilation/asserts)

Aras Pranckevicius aras at unity3d.com
Fri Oct 22 01:53:03 PDT 2010


Hi,

Attached patch fixes what looks like a typo in ir_algebraic GLSL optimizations.

Vertex shader that triggers the bug:

void main() {
    gl_Position = gl_ModelViewProjectionMatrix * gl_Vertex;
    mat3 m = mat3 (0.1, 0.8, 0.1, 0.3, 0.3, 0.5, 0.9, 0.0, 0.1);
    vec3 n = m * gl_Normal;
    gl_FrontColor = vec4(n*0.5+0.5, 1.0);
}


(in debug build, triggers assert; miscompiled shader in release build)


--
Aras Pranckevičius
work: http://unity3d.com
home: http://aras-p.info
-------------- next part --------------
A non-text attachment was scrubbed...
Name: glsl-fix-matrix-type-check-in-ir_algebraic.patch
Type: application/octet-stream
Size: 948 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20101022/9798c77d/attachment.obj>


More information about the mesa-dev mailing list