[Mesa-dev] [PATCH 00/10] glsl: Add support for AMD_conservative_depth in compiler front-end

[Chad Versace]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Ian, I've addressed the issues you raised with the patch sequence.
Rather than spamming the mailing list with the new patches, though, I'll
just point to the Gitweb.

gitweb:
http://cgit.freedesktop.org/~chadversary/mesa/log/?h=AMD_conservative_depth

> I think these functions should be moved to glsl_parser_extras.cpp. All
> of the other "parser helper" functions live there.

Fixed in these two commits:
- - glsl: Refactor parser rule of layout_qualifier_id
- - glsl: Add support for AMD_conservative_depth to bison file

> There aren't any linker changes.  Linking should fail when an
> application tries to link shaders with conflicting layouts.

Fixed in this commit:
glsl: Cause linking error if some layout qualifiers do not match

> The gl_FragDepth layout should get propagated up into the
> gl_fragment_program in the same way as the gl_FragCoord layout.  The
> setting in gl_fragment_program should be an enum instead of a set of
> distinct bit flags (as is used in ir_variable).

Fixed in this commit:
mesa/program: Propagate gl_FragDepth layout to gl_fragment_program

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJMxicyAAoJEAIvNt057x8iF4AP/0wRMz7lD2SsM6U6/SxqgMr+
qQIXOeP1bVVCOzlxUDVixXxl2/kVPHT3eZuMAlPgoaDX99BisphfP0pbCtVEPndO
zi2+NjfZr5urwTVOZ+1PJtJPozkuvKgs1aFa2+GAieNBqa0jsMtQzZHowfRXKwAd
Jpel4ldAIy9SmijleIzYXGo81LenHNZrCMfz9uG86WdQ/wPkq/WoE3YTk6IMv8cC
gM/4qcF41R/2TmY8melxvZ0t2YO+zhzyYrrwqwX+gKB5uBzWl8pFu4sC7qwLbQnb
TYIj330DjxHhL+PYmjVhQWRgJ3xNooNCSCiIWP6LdwSWT2avuLSU2DIoqFH/JBoN
92Abh5bJ4JZLZQUGbg8mHFXDE2MeVp+fioFb+bUCpYgMyhPdMayCXIedIxSRrcVJ
srCcvRa/RwlCcYx3GHS5FYaWBsLg/1fcTdoozN2HPFJHJbtsuOUQ/kQmUBPnfLzi
Jw499Zekhbl1jp69cFI/T28K5ov0LqbDqzbkiEP6f4SfuF4voktFDSwCcd0TxJTN
+EjJ/iT/AOrueJHHUNvo4ze7JTMZZy0FUPM26FK87Vr9FD2qokPyA45a6FQ0Qg0Q
lxxKjfF+lRnJg84yLnTmCuHe2bfOme2pnVHWfIW6BipUlqw6i2U+A8g0926V9mWS
H6bYWlqyviiALv0G9qVa
=IqBR
-----END PGP SIGNATURE-----