[Mesa-dev] [PATCH 2/3] glsl: add AMD_vertex_shader_layer support

[Kenneth Graunke]

On 05/01/2013 09:25 PM, Jordan Justen wrote:
> On Wed, May 1, 2013 at 9:13 PM, Matt Turner <mattst88 at gmail.com> wrote:
>> On Wed, May 1, 2013 at 8:41 PM, Jordan Justen <jljusten at gmail.com> wrote:
>>> On Tue, Apr 30, 2013 at 10:01 AM, Jordan Justen <jljusten at gmail.com> wrote:
>>>> On Tue, Apr 30, 2013 at 9:57 AM, Ian Romanick <idr at freedesktop.org> wrote:
>>>>> On 04/27/2013 04:32 PM, Jordan Justen wrote:
>>>>>>
>>>>>> This GLSL extension requires that AMD_vertex_shader_layer be
>>>>>> enabled by the driver.
>>>>>
>>>>> Most (all?) extensions also add a preprocessor define.  Can you poke at
>>>>> AMD's driver to see if GL_AMD_vertex_shader_layer is defined?  If so, then
>>>>> we need to add it too.
>>>>
>>>> Unfortunately, I don't have an AMD card.
>>>>
>>>> Anuj tried my piglit test with his AMD card, and found the extension
>>>> wasn't available.
>>>
>>> Anuj updated his driver, and now the extension is available.
>>>
>>> Is this series r-b you pending resolution of the define issue?
>>
>> His question about the preprocessor definition is still unanswered, as
>> far as I can tell.
>
> "pending resolution" meant I'd figure out what the AMD driver is
> doing, and follow that.
>
> -Jordan

All modern extensions are supposed to have a #define...they probably 
just forgot.  We should just do it anyway, even if they don't.

--Ken