[Mesa-dev] [PATCH] gallium: fix type of flags in pipe_context::flush()

Jose Fonseca jfonseca at vmware.com
Fri May 3 01:00:07 PDT 2013


----- Original Message -----
> It should be unsigned, not enum pipe_flush_flags.
> 
> Fixed a build error:
> 
>   src/gallium/state_trackers/egl/android/native_android.cpp:426:29: error:
>   invalid conversion from 'int' to 'pipe_flush_flags' [-fpermissive]
> 

While I agree that using enum for bitmasks is not a great idea, I think it is a bit too late to go back on this now, as enum pipe_flush_flags is now used all over the place.  Please just add (enum pipe_flush_flags) cast to silence.  That is what is done in other cpp files.

Jose


More information about the mesa-dev mailing list