[Mesa-dev] [PATCH] mesa: Be less casual about texture formats in st_finalize_texture

[Marek Olšák]

Sorry, I'm not following. Which commit of mine are you referring to?

Marek

On Wed, May 8, 2013 at 2:56 AM, Dave Airlie <airlied at gmail.com> wrote:
> On Wed, May 8, 2013 at 1:14 AM, Brian Paul <brianp at vmware.com> wrote:
>> On 05/06/2013 02:41 PM, Adam Jackson wrote:
>>>
>>> Commit 62452883 removed a hunk like
>>>
>>>      if (firstImageFormat != stObj->pt->format)
>>>          st_view_format = firstImageFormat;
>>>
>>> from update_single_texture().  This broke piglit/glx-tfp on AMD Barts
>>> (and probably others), as that hunk was compensating for the mesa and
>>> gallium layers disagreeing about the format.
>>>
>>> Fix this by not ignoring the alpha channel in st_finalize_texture when
>>> considering whether two 32-bit formats are sufficiently compatible.
>>
>>
>> It looks like you're undoing change a2817f6ae by Dave Airlie.
>>
>> Dave should review this.  It's not 100% clear to me what's going on there.
>
> I think I'd rather put back what Marek's change undid than remove the
> alpha channel stuff,
> I put all that in for a good reason, if memory serves things either
> went a lot slower
> or stuff misrendered in gnome-shell without it.
>
> Dave.