[Mesa-dev] [PATCH] gallium/tgsi: clarify (possibly change) TGSI_OPCODE_UCMP definition

Roland Scheidegger sroland at vmware.com
Wed May 8 19:48:12 PDT 2013


Am 09.05.2013 03:55, schrieb Bryan Cain:
> On 05/08/2013 03:26 PM, Roland Scheidegger wrote:
>> There's some other
>> somewhat bogus code with comments saying UCMP should be used instead of
>> some poor emulation with i2f instructions.
> 
> Yeah, sorry about that.  I wrote that code (and comment) a few days
> before the UCMP opcode was added to TGSI, and didn't notice until today
> that it was never updated to actually use UCMP.  There are a few changes
> and clean-ups I've been wanting to make to glsl_to_tgsi anyway - I'll
> include an update to emit UCMP if someone hasn't already done so by the
> time I finish that and send out a patch set.
> 

I looked at it and it's not really that bogus after all just suboptimal.
But seemed to require too much effort to fix quickly, so I only bothered
to fix the weird USNE/UCMP with negation sequence.

Roland


More information about the mesa-dev mailing list