[Mesa-dev] [PATCH] i965: verify depth render buffer depth when in fast clear WIP

[Tapani Pälli]

On 05/08/2013 08:06 PM, Eric Anholt wrote:
> Tapani Pälli <tapani.palli at intel.com> writes:
> 
>> Patch makes sure in conservative way that the depth_clear_value
>> is correct and represents max depth of current depth buffer.
>>
>> This fixes the case where user has 16bit color buffer but 24bit
>> depth buffer and 'fb->_DepthMax' has a wrong value. I'm currently
>> investigating how to get _DepthMax corrected on mesa side, but
>> meanwhile this patch will enable correct rendering results for
>> 16bit benchmarks instead of displaying only white color on the
>> screen. This bug does not happen with user created framebuffers,
>> only with window system ones.
> 
> _DepthMax should actually get fixed, instead.  _DepthMax should have
> nothing to do with color bits per pixel.
> 


Yes I agree, I'm investigating the root cause in framebuffer
renderbuffer mgmt. I know color buffer depth should not matter here but
that is basically the environment where bug is currently reproduced.

// Tapani


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 555 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130509/476dbfea/attachment.pgp>