[Mesa-dev] [PATCH] intel: Don't spam "intelReadPixels: fallback to swrast" in non-PBO case.

[Eric Anholt]

Kenneth Graunke <kenneth at whitecape.org> writes:

> When an application is using PBOs, we attempt to use the BLT engine to
> perform ReadPixels.  If that fails due to some restrictions, it's useful
> to raise a performance warning.
>
> In the non-PBO case, we always use a CPU mapping since getting the data
> into client memory requires a CPU-side copy.  This is a very common case,
> so raising a performance warning is annoying.  In particular, apitrace's
> image dumping code hits this path, causing it to print hundreds of
> thousands of performance warnings via ARB_debug_output.  This tends to
> obscure actual errors or other important messages.

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130516/393dc966/attachment.pgp>