[Mesa-dev] [PATCH] st/mesa: Remove unused variable 'texImage'.

Jose Fonseca jfonseca at vmware.com
Fri May 17 07:46:43 PDT 2013


_mesa_get_attachment_teximage has no side effects so looks good to me.

Jose


----- Original Message -----
> All uses of 'texImage' were removed in commit
> 77a405dba7f70f8a47655e90774a5ecf5c88a6ed.
> 
> Fixes "Unused pointer value" defect reported by Coverity.
> 
> Signed-off-by: Vinson Lee <vlee at freedesktop.org>
> ---
>  src/mesa/state_tracker/st_cb_fbo.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/src/mesa/state_tracker/st_cb_fbo.c
> b/src/mesa/state_tracker/st_cb_fbo.c
> index aa245d3..457cec1 100644
> --- a/src/mesa/state_tracker/st_cb_fbo.c
> +++ b/src/mesa/state_tracker/st_cb_fbo.c
> @@ -394,7 +394,6 @@ st_render_texture(struct gl_context *ctx,
>     struct st_renderbuffer *strb = st_renderbuffer(rb);
>     struct pipe_resource *pt;
>     struct st_texture_object *stObj;
> -   const struct gl_texture_image *texImage;
>     struct pipe_surface surf_tmpl;
>  
>     if (!st_finalize_texture(ctx, pipe, att->Texture))
> @@ -403,9 +402,6 @@ st_render_texture(struct gl_context *ctx,
>     pt = st_get_texobj_resource(att->Texture);
>     assert(pt);
>  
> -   /* get pointer to texture image we're rendeing to */
> -   texImage = _mesa_get_attachment_teximage(att);
> -
>     /* get the texture for the texture object */
>     stObj = st_texture_object(att->Texture);
>  
> --
> 1.8.2.1
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
> 


More information about the mesa-dev mailing list