[Mesa-dev] Gen6+ hardware contexts & query object improvements

[Paul Berry]

On 17 May 2013 10:17, Kenneth Graunke <kenneth at whitecape.org> wrote:

> Hello!
>
> This patch series bumps the kernel requirement to 3.6 for Gen6+,
> meaning that we actually get to rely on hardware context support.
> That's a little painful, but even Debian ships 3.8 now, and this
> isn't going to make it into an actual release for several more
> months.
>
> It then splits our query code into Gen4-5 and Gen6+ versions.  The new
> Gen6+ version is a lot simpler since hardware contexts guarantee that
> our statistics registers don't get polluted with data from other
> programs running on the system.  It should be more efficient, which
> may help games like Minecraft (though I haven't measured).
>
> Finally, it implements the GL_PRIMITIVES_GENERATED and
> GL_TRANSFORM_FEEDBACK_PRIMITIVES_WRITTEN queries via hardware counters
> rather than manually counting on the CPU.  This paves the way for
> geometry shader support (which can output multiple primitives, breaking
> our CPU-side tracking), and should allow us to enable hardware primitive
> restart in a few more cases once a few more things are tidied.
>
> The next step is to eliminate the use of SOL reset and save/restore the
> transform feedback offsets directly.  Then we can turn on hardware
> primitive restart more aggressively and implement a few more transform
> feedback extensions.
>
> Thanks in advance for the review.
>
> --Ken
>

I made comments on patches 1, 2, 5, 9, and 10.  I agree with Eric's
comments on patch 7.  The remaining patches are:

Reviewed-by: Paul Berry <stereotype441 at gmail.com>



>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130520/e988d72b/attachment.html>