[Mesa-dev] [PATCH 1/5] i965: Shut up more compiler warnings from vector insert/extract changes.
Ian Romanick
idr at freedesktop.org
Wed May 22 12:09:09 PDT 2013
Patches 1 and 2 are
Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
I had comments on 3 and 5.
On 05/21/2013 06:11 PM, Eric Anholt wrote:
> ---
> src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp b/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp
> index b7bbaab..36d9cf0 100644
> --- a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp
> @@ -493,6 +493,14 @@ fs_visitor::visit(ir_expression *ir)
> assert(!"not reached: should be handled by lower_quadop_vector");
> break;
>
> + case ir_binop_vector_extract:
> + assert(!"not reached: should be handled by lower_vec_index_to_cond_assign()");
> + break;
> +
> + case ir_triop_vector_insert:
> + assert(!"not reached: should be handled by lower_vector_insert()");
> + break;
> +
> case ir_unop_sqrt:
> emit_math(SHADER_OPCODE_SQRT, this->result, op[0]);
> break;
>
More information about the mesa-dev
mailing list