[Mesa-dev] [PATCH 3/5] mesa: Fix test for optimistic coloring being necessary.

[Eric Anholt]

Ian Romanick <idr at freedesktop.org> writes:

> On 05/21/2013 06:11 PM, Eric Anholt wrote:
>> i965 and radeon use ra_set_node_reg() to force payload registers to
>> specific registers while exposing those registers to the allocator still.
>> We were treating those register nodes as unsuccessfully allocated in the
>> ra_simplify() step, leading to walking the registers again to do
>> optimistic coloring even if there was nothing left ot do.
>                                                       ^^ to
>
> How would this bug manifest?  How do we know this fixes it?  From the 
> other commit messages, I suspect this only shows with patches 4 and 5. 
> Yeah?

I noticed it stepping through the register allocator while debugging my
conservative coalescing changes (not sent out for review).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130522/d00d0651/attachment.pgp>