[Mesa-dev] [v6 2/9] intel: do not create renderbuffers out of planar images

[Eric Anholt]

Topi Pohjolainen <topi.pohjolainen at intel.com> writes:

> Signed-off-by: Topi Pohjolainen <topi.pohjolainen at intel.com>
> ---
>  src/mesa/drivers/dri/intel/intel_fbo.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/src/mesa/drivers/dri/intel/intel_fbo.c b/src/mesa/drivers/dri/intel/intel_fbo.c
> index 69f8629..7ccbaa8 100644
> --- a/src/mesa/drivers/dri/intel/intel_fbo.c
> +++ b/src/mesa/drivers/dri/intel/intel_fbo.c
> @@ -280,6 +280,10 @@ intel_image_target_renderbuffer_storage(struct gl_context *ctx,
>     if (image == NULL)
>        return;
>  
> +   /* Planar buffers are not supported as render targets. */
> +   if (image->planar_format && image->planar_format->nplanes > 1)
> +      return;
> +
>     /* __DRIimage is opaque to the core so it has to be checked here */
>     switch (image->format) {
>     case MESA_FORMAT_RGBA8888_REV:

OK, this answers one question I had about what our support was going to
be.  But what about glEGLImageTargetTexture2DOES()?

Are we only going to support planar textures with image_external?  My
thought is "yes".  How about on HSW with the YUV sampler support?  Are
we going to relayout the data in the incoming fds to a copy that can
support sampling from them, or are we going to reject incoming fds that
don't fit the required layout?  And if we decide to reject anything, are
we going to reject it at the or the dmabuf_import stage or the
image_external stage?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130528/8ddf5642/attachment-0001.pgp>