[Mesa-dev] [PATCH] mesa: fix error checking of DXT sRGB formats in _mesa_base_tex_format()

[Brian Paul]

On 05/30/2013 09:56 AM, Eric Anholt wrote:
> Brian Paul <brianp at vmware.com> writes:
>
>> For formats such as GL_COMPRESSED_SRGB_S3TC_DXT1_EXT we need to
>> have both the GL_EXT_texture_sRGB and GL_EXT_texture_compression_s3tc
>> extensions.  This patch adds the missing check for the later.
>>
>> Found when checking out https://bugs.freedesktop.org/show_bug.cgi?id=65173
>
> Ah, this patch was a bit confusing without the context of "if
> (ctx->Extensions.EXT_texture_sRGB) {" wrapping the switch statement.
>
> Reviewed-by: Eric Anholt <eric at anholt.net>
>
> On a similar note, looks like we're allowing a lot of extension-provided
> L/LA/A/I formats on core.

Is that something you (or another else) can take care of?

-Brian