[Mesa-dev] [PATCH] glapi: Add some missing static_dispatch="false" annotations to es_EXT.xml

[Brian Paul]

The change looks OK to me.

Reviewed-by: Brian Paul <brianp at vmware.com>

On 05/31/2013 04:29 AM, Andreas Boll wrote:
> FYI here is the full build log of the failing build.
>
> https://buildd.debian.org/status/fetch.php?pkg=mesa&arch=powerpc&ver=9.1.3-1&stamp=1369778584
>
> Andreas.
>
>
> 2013/5/30 Andreas Boll <andreas.boll.dev at gmail.com
> <mailto:andreas.boll.dev at gmail.com>>
>
>     This fixes the following build errors on powerpc:
>
>        CC     glapi_dispatch.lo
>        In file included from glapi_dispatch.c:90:0:
>        ../../../../../src/mapi/glapi/glapitemp.h:1640:1: error: no previous
>        prototype for 'glReadBufferNV' [-Werror=missing-prototypes]
>        ../../../../../src/mapi/glapi/glapitemp.h:4198:1: error: no previous
>        prototype for 'glDrawBuffersNV' [-Werror=missing-prototypes]
>        ../../../../../src/mapi/glapi/glapitemp.h:6377:1: error: no previous
>        prototype for 'glFlushMappedBufferRangeEXT'
>        [-Werror=missing-prototypes]
>        ../../../../../src/mapi/glapi/glapitemp.h:6389:1: error: no previous
>        prototype for 'glMapBufferRangeEXT' [-Werror=missing-prototypes]
>        ../../../../../src/mapi/glapi/glapitemp.h:6401:1: error: no previous
>        prototype for 'glBindVertexArrayOES' [-Werror=missing-prototypes]
>        ../../../../../src/mapi/glapi/glapitemp.h:6413:1: error: no previous
>        prototype for 'glDeleteVertexArraysOES' [-Werror=missing-prototypes]
>        ../../../../../src/mapi/glapi/glapitemp.h:6433:1: error: no previous
>        prototype for 'glGenVertexArraysOES' [-Werror=missing-prototypes]
>        ../../../../../src/mapi/glapi/glapitemp.h:6445:1: error: no previous
>        prototype for 'glIsVertexArrayOES' [-Werror=missing-prototypes]
>
>     NOTE: This is a candidate for the 9.0 and 9.1 branches.
>
>     Reviewed-by: Maarten Lankhorst <maarten.lankhorst at canonical.com
>     <mailto:maarten.lankhorst at canonical.com>>
>     ---
>       src/mapi/glapi/gen/es_EXT.xml |   23 ++++++++++++++---------
>       1 file changed, 14 insertions(+), 9 deletions(-)
>
>     diff --git a/src/mapi/glapi/gen/es_EXT.xml
>     b/src/mapi/glapi/gen/es_EXT.xml
>     index ff378ac..f412333 100644
>     --- a/src/mapi/glapi/gen/es_EXT.xml
>     +++ b/src/mapi/glapi/gen/es_EXT.xml
>     @@ -689,22 +689,25 @@
>
>       <!-- 71. GL_OES_vertex_array_object -->
>       <category name="GL_OES_vertex_array_object" number="71">
>     -    <function name="BindVertexArrayOES" alias="BindVertexArray"
>     es2="2.0">
>     +    <function name="BindVertexArrayOES" alias="BindVertexArray"
>     +              static_dispatch="false" es2="2.0">
>               <param name="array" type="GLuint"/>
>           </function>
>
>           <function name="DeleteVertexArraysOES" alias="DeleteVertexArrays"
>     -              es2="2.0">
>     +              static_dispatch="false" es2="2.0">
>               <param name="n" type="GLsizei"/>
>               <param name="arrays" type="const GLuint *" count="n"/>
>           </function>
>
>     -    <function name="GenVertexArraysOES" alias="GenVertexArrays"
>     es2="2.0">
>     +    <function name="GenVertexArraysOES" alias="GenVertexArrays"
>     +              static_dispatch="false" es2="2.0">
>               <param name="n" type="GLsizei"/>
>               <param name="arrays" type="GLuint *" output="true" count="n"/>
>           </function>
>
>     -    <function name="IsVertexArrayOES" alias="IsVertexArray" es2="2.0">
>     +    <function name="IsVertexArrayOES" alias="IsVertexArray"
>     +              static_dispatch="false" es2="2.0">
>               <param name="array" type="GLuint"/>
>               <return type="GLboolean"/>
>           </function>
>     @@ -779,7 +782,8 @@
>               <size name="Get" mode="get"/>
>           </enum>
>
>     -    <function name="DrawBuffersNV" alias="DrawBuffers" es2="2.0">
>     +    <function name="DrawBuffersNV" alias="DrawBuffers"
>     +              static_dispatch="false" es2="2.0">
>               <param name="n" type="GLsizei" counter="true"/>
>               <param name="bufs" type="const GLenum *" count="n"/>
>           </function>
>     @@ -787,7 +791,8 @@
>
>       <!-- 93. GL_NV_read_buffer -->
>       <category name="GL_NV_read_buffer">
>     -    <function name="ReadBufferNV" alias="ReadBuffer" es2="2.0">
>     +    <function name="ReadBufferNV" alias="ReadBuffer"
>     +              static_dispatch="false" es2="2.0">
>               <param name="mode" type="GLenum"/>
>           </function>
>       </category>
>     @@ -815,8 +820,8 @@
>           <enum name="MAP_FLUSH_EXPLICIT_BIT_EXT"
>     value="0x0010"/>
>           <enum name="MAP_UNSYNCHRONIZED_BIT_EXT"
>     value="0x0020"/>
>
>     -    <function name="MapBufferRangeEXT" alias="MapBufferRange" es1="1.0"
>     -              es2="2.0">
>     +    <function name="MapBufferRangeEXT" alias="MapBufferRange"
>     +              static_dispatch="false" es1="1.0" es2="2.0">
>               <param name="target" type="GLenum"/>
>               <param name="offset" type="GLintptr"/>
>               <param name="size" type="GLsizeiptr"/>
>     @@ -825,7 +830,7 @@
>           </function>
>
>           <function name="FlushMappedBufferRangeEXT"
>     alias="FlushMappedBufferRange"
>     -              es1="1.0" es2="2.0">
>     +              static_dispatch="false" es1="1.0" es2="2.0">
>               <param name="target" type="GLenum"/>
>               <param name="offset" type="GLintptr"/>
>               <param name="length" type="GLsizeiptr"/>
>     --
>     1.7.10.4
>
>
>
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>