[Mesa-dev] [PATCH RFC 2/2] dri: Pass a __DRIcontext to ->set_damage_region()

[Daniel Stone]

Hi Boris,

On Tue, 1 Oct 2019 at 09:25, Boris Brezillon
<boris.brezillon at collabora.com> wrote:
> On Mon, 2 Sep 2019 16:32:01 +0200 Michel Dänzer <michel at daenzer.net> wrote:
> > On 2019-08-30 7:00 p.m., Boris Brezillon wrote:
> > > So, next question is, do you think it's acceptable to pass a
> > > DRIcontext here, and if not, do you have any idea how to solve this
> > > problem?
> >
> > Hmm, not sure. Maybe it would be better to explicitly pass in the
> > __DRIimage* to which the damage region applies?
>
> Sorry, for the late reply. I had a look at this proposal and I don't see
> how passing a __DRIimage object would help. There's this comment [1]
> that makes me think passing a drawable is the right thing to do, but at
> the same time I'm not sure how to rework the logic to make it work
> without having access to the pipe_context (sounds like an invasive
> change to me).
> So, I suggest that we revert [2] and [3] until we find a proper
> solution to address the problem.
>
> Daniel, Qiang, are you okay with that?

Yeah, I'm fine with that.

I can't remember the details of why passing a DRIimage directly
doesn't help. Writing that down somewhere would be good, I think.

Cheers,
Daniel