approval_X11R6.8.x requested: [Bug 1490] DDC code confused by EDID V1.3 : [Attachment 1122] Fix

[Thomas Winischhofer]

bugzilla-request-daemon at freedesktop.org wrote:
> Alan Coopersmith <alan.coopersmith at sun.com> has asked  for approval_X11R6.8.x:
> Bug 1490: DDC code confused by EDID V1.3
> https://bugs.freedesktop.org/show_bug.cgi?id=1490
> 
> Attachment 1122: Fix
> https://bugs.freedesktop.org/attachment.cgi?id=1122&action=edit
> _______________________________________________
> release-wranglers mailing list
> release-wranglers at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/release-wranglers
> 

-------

-get_display_section(Uchar *c, struct disp_features *r)
+get_display_section(Uchar *c, struct disp_features *r,
+		    struct edid_version *v)
  {
      r->input_type = INPUT_TYPE;
-    r->input_voltage = INPUT_VOLTAGE;
-    r->input_setup = SETUP;
-    r->input_sync = SYNC;
+    if (!DIGITAL(r->input_type)) {
+	r->input_voltage = INPUT_VOLTAGE;
+	r->input_setup = SETUP;
+	r->input_sync = SYNC;
+    } else if (v->version > 1 || v->revision > 2)
+	r->input_dfp = DFP;
      r->hsize = HSIZE_MAX;
      r->vsize = VSIZE_MAX;
      r->gamma = GAMMA;
@@ -97,15 +115,20 @@
  }

------

Hm, where is it stated that the "digital input" bit requires EDID 
version >= 1.3?

The EDID v3 document I have (Extended Display Identification data 
standard Version 3, Nov 13 1997) only says that digital input "requires 
use of" EDID V2.x (which is something completely different than EDID v1.2).

On page 9 of that document, the differences between EDID v1.1 and 1.2 
are outlined as follows:

"EDID structure Version 1 Revision 2 defines uses for two previously 
reserved bits in the features support byte and allows for additional 
manufacturer specific alternate definitions of the detailed timing 
descriptions".

Not a word on the digital input bit, though.

Can anyone enlighten me?

Thomas


-- 
Thomas Winischhofer
Vienna/Austria
thomas AT winischhofer DOT net	       *** http://www.winischhofer.net
twini AT xfree86 DOT org