Corrupted display (radeon_accelfuncs.c)

Jerome Glisse j.glisse at free.fr
Sun Dec 26 14:11:17 PST 2004


I am not sure but i think there is a typo bug

in radeon_accel.c line 657 this should be
    if (bpp == 2)
    OUT_RING_REG(RADEON_RBBM_GUICNTL,   RADEON_HOST_DATA_SWAP_16BIT);
    else if (bpp == 4)
    OUT_RING_REG(RADEON_RBBM_GUICNTL,   RADEON_HOST_DATA_SWAP_32BIT);
    else
    OUT_RING_REG(RADEON_RBBM_GUICNTL,   RADEON_HOST_DATA_SWAP_NONE);
    ADVANCE_RING();

Instead of
    if (bpp == 2)
    OUT_RING_REG(RADEON_RBBM_GUICNTL,   RADEON_HOST_DATA_SWAP_16BIT);
    else if (bpp == 1)
    OUT_RING_REG(RADEON_RBBM_GUICNTL,   RADEON_HOST_DATA_SWAP_32BIT);
    else
    OUT_RING_REG(RADEON_RBBM_GUICNTL,   RADEON_HOST_DATA_SWAP_NONE);
    ADVANCE_RING();

Or did i misunderstood bpp magic :) ?
Anyway this does not fix the problem of corrupted display.

best,
Jerome Glisse



More information about the xorg mailing list