render improvements
Keith Packard
keithp at keithp.com
Wed Jun 15 12:52:53 PDT 2005
On Wed, 2005-06-15 at 19:37 +0200, Zack Rusin wrote:
> This is an artifact of our emacs configurations. It's only a problem because
> the freedesktop cvs script generates funky patches.
No, the freedesktop CVS script shows the entire patch, not
just the 'non-whitespace' changes.
> We could remove it but a
> lot more general and proper fix would be to simply add -b -B switches to the
> script that generates the diff on the server.
No. I want to see whitespace changes because these
may well mark errors in old or new code
if (foo)
bar;
- bletch;
+ bletch;
is rather important to see.
Where whitespace makes the code ambiguous or possible wrong, a patch
that fixes that would be fine, but automatically modifying code in
invisible ways doesn't seem to me to have any value at all.
-keith
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg/attachments/20050615/68924539/attachment.pgp>
More information about the xorg
mailing list