Need review for #3180 please

Alan Coopersmith Alan.Coopersmith at Sun.COM
Mon Nov 7 18:08:32 PST 2005


Kean Johnston wrote:
> https://bugs.freedesktop.org/show_bug.cgi?id=3180
> 
> I just uploaded a new patch against today's HEAD. This is
> significantly more improved than the last patch, and addresses
> OpenServer 6 as well as OpenServer 5 and UnixWare 7. T

Looks fairly good to me.   Specific comments:

  - lib/X11/XKeysymDB: Shouldn't the SCO keysyms be in the range
    reserved for vendor additions?  (0x10000000 to 0x1FFFFFFF).
    The values you've listed are in the range reserved for X.Org
    to assign, which should be restricted to the Architecture Working
    Group.

  - programs/Xserver/hw/xfree86/parser/Monitor.c:  I'm curious
    why you change the default for SCO to uncommenting the monitor
    ranges by default - seems strange to be a OS-specific option.

  - programs/xterm/main.c:  This should be reported to Thomas Dickey.
    We're just mirroring his xterm sources in Xorg right now for 6.9,
    and telling users to pull directly from his sources for the
    modular builds.

-- 
	-Alan Coopersmith-           alan.coopersmith at sun.com
	 Sun Microsystems, Inc. - X Window System Engineering



More information about the xorg mailing list