Need review for #3180 please
Alan Coopersmith
Alan.Coopersmith at Sun.COM
Mon Nov 7 23:41:07 PST 2005
Kean Johnston wrote:
>
>> So it should probably depend on whether or not it's being called from
>> xorgcfg, not #ifdef'ed per OS - perhaps adding a boolean to
>> XF86ConfMonitorRec
>> to specify whether the numbers were being overridden and have xorgcfg
>> set that when needed - unfortunately, I'm not familiar enough with this
>> part of the system to know how good an idea that is.
>
> Personally I think its overkill. I think the current code
> in Monitor.c is just plain wrong, especially from an intuitive
> point of view. The purpose of that code is to write out config
> entries based on input values. The way it currently stands, it
> is ignoring those values and applying other semantics to it,
> thus knowing that if you leave them all undefined, you get DDC.
Actually, I've just realized this is the same thing Mike Harris filed
as Xorg bugzilla #1223 a while ago. I don't know why that was never
checked in.
--
-Alan Coopersmith- alan.coopersmith at sun.com
Sun Microsystems, Inc. - X Window System Engineering
More information about the xorg
mailing list