RFC: Bug #4633 (Initial mouse pointer incorrect with EXA)

[Michel Dänzer]

On Fri, 2005-11-11 at 16:30 +0000, Alan Hourihane wrote:
> On Fri, 2005-11-11 at 17:21 +0100, Michel Dänzer wrote:
> > On Fri, 2005-11-11 at 11:05 +0000, Alan Hourihane wrote:
> > > On Fri, 2005-11-11 at 11:51 +0100, Michel Dänzer wrote:
> > > > 
> > > >       * xf86RandRSetMode() might be able to take care of this by calling
> > > >         something like UnrealizeCursor() before disabling FB access and
> > > >         RealizeCursor() after re-enabling it.
> > > 
> > > I think I like this approach best. It'll also cure Thomas' problem with
> > > the SiS rotation and hw cursor upload.
> > 
> > Thanks for reminding me of that, and thank you, Ben and Thomas for your
> > feedback in general. You've convinced me that this is the best of the
> > three approaches I listed. However, on second though, I think it would
> > be even better if EnableDisableFBAccess() itself took care of it
> > implicitly rather than xf86RandRSetMode() explicitly. That should also
> > remove the need for kludges such as the fix for bug #4951, e.g.
> > 
> > Do you guys agree? If so, any preferences for the level at which
> > EnableDisableFBAccess() should do this?
> 
> I agree that EnableDisableFBAccess is probably the better place to do
> this too.

Here's a patch that adds an EnableDisableFBAccess() hook to the ramdac
module and removes its {Enter,Leave}VT() and SetDGAMode() hooks in
favour of it. Tested with xrandr, VT switching and dga(1x). Pierre, does
this fix your issue? Thomas, does this help for HW cursor rotation?
Other comments?


-- 
Earthling Michel Dänzer      |     Debian (powerpc), X and DRI developer
Libre software enthusiast    |   http://svcs.affero.net/rm.php?r=daenzer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ramdac-fbaccess.diff
Type: text/x-patch
Size: 7179 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg/attachments/20051115/cbe002bf/attachment.bin>