TRANS_NOXAUTH

[Jeremy Huddleston]

On Aug 6, 2008, at 09:09, Adam Jackson wrote:

> On Wed, 2008-08-06 at 09:13 +0300, Daniel Stone wrote:
>> On Tue, Aug 05, 2008 at 07:09:21PM -0700, Jeremy Huddleston wrote:
>>> +    if(trans_conn->flags | TRANS_NOXAUTH) {
>>                            ^
>>                            & ?

 >< ... yes, thank you Daniel... that would've been bad.

>>
>>
>>> +        auth_id = (XID) 0L;
>>> +    } else {
>>> +        auth_id = CheckAuthorization (proto_n, auth_proto,  
>>> string_n,
>>> auth_string, client, &reason);
>>> +    }
>
> Yes, definitely that.
>
> There's no new xtrans release with NOXAUTH yet, so if you'd also add a
>
> #ifndef TRANS_NOXAUTH
> #define TRANS_NOXAUTH 0
> #endif
>
> in the appropriate place, then this looks fine for master, and we can
> just cull the ifdef once new xtrans goes out.

Ok ... but I think I'll do (1<<6) or whatever it was in xtrans unless  
there's some reason you really want the 0.

--Jeremy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 3040 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg/attachments/20080806/38fc062b/attachment.bin>