xf86-video-ati: [PATCH] Janitor: make distcheck, .gitignore.

Paulo César Pereira de Andrade pcpa at mandriva.com.br
Thu Feb 5 15:23:54 PST 2009


  I am starting to believe that, maybe -Wpointer-arith should
not only be out of $CWARNFLAGS, but that $CWARNFLAGS should
actually include -Wno-pointer-arith.
  Almost every "casting" is a sign of something going wrong,
as the compiler should always able to do proper type
conversion automatically, and changing the void *'s in the
ati driver to something like an "unsigned char *" just to
correct that warning may not be the proper solution.

  A "Janitor: Fix compiler warnings" should also be
done, to add declarations to headers, and move
prototypes in C files to H ones (I started doing that,
but I also done a wrong "git reset --hard" and lost it,
maybe next time :-)...

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Janitor-make-distcheck-.gitignore.patch
Type: text/x-patch
Size: 3961 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg/attachments/20090205/698a7212/attachment.bin>


More information about the xorg mailing list