Xorg R7.6 mesa/egl Makefile fixing in Ubuntu 10.10

[Chen, Dennis (SRDC SW)]

Hi man, you can try it in ubuntu system...
But the issue "can't find the X11/Xlib.h" is in the source codes from the git, maybe the version is not R7.6 since I found that there're some different in xserver source code between the git database and download from the www.x.org Xorg R7.6 release...

Dennis

-----Original Message-----
From: xorg-bounces+dennis1.chen=amd.com at lists.freedesktop.org [mailto:xorg-bounces+dennis1.chen=amd.com at lists.freedesktop.org] On Behalf Of Alan Coopersmith
Sent: 2011年2月22日 0:45
To: xorg at lists.freedesktop.org
Subject: Re: Xorg R7.6 mesa/egl Makefile fixing in Ubuntu 10.10

On 02/21/11 12:05 AM, Chen, Dennis (SRDC SW) wrote:
> Hi All,
> 
>  
> 
> I found that current the Makefile of mesa/mesa/src/egl/main in X11 R7.6 has the
> below line:
> 
>  
> 
> INCLUDE_DIRS = -I$(TOP)/include
> 
>  
> 
> When build the mesa module in Ubuntu system, this will led to a build error
> complaining “can’t find the X11/Xlib.h”, that’s because in ubuntu, the Xlib.h is
> located in /usr/include/X11 by default, so I think

That's where Xlib.h is located on most systems.

> The Makefile should be changed to:
> 
> INCLUDE_DIRS = -I$(TOP)/include -I/usr/include/X11

That doesn't make sense.   The #include path is relative to the -I path,
so you've just specified that #include <X11/Xlib.h> should be looking for
/usr/include/X11/X11/Xlib.h.

Compilers normally include -I/usr/include by default so no -I flag is needed
for #include <X11/Xlib.h> to find /usr/include/X11/Xlib.h.

-- 
	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System

_______________________________________________
xorg at lists.freedesktop.org: X.Org support
Archives: http://lists.freedesktop.org/archives/xorg
Info: http://lists.freedesktop.org/mailman/listinfo/xorg
Your subscription address: dennis1.chen at amd.com