A couple of patches to configure the private bin directory

[José Fonseca]

On Tue, Nov 1, 2011 at 11:50 PM, Carl Worth <cworth at cworth.org> wrote:
> On Tue, 01 Nov 2011 13:41:35 -0700, Carl Worth <cworth at cworth.org> wrote:
>> I think with your version of this change, trying to run the GUI when
>> it's compiled-but-not-yet-installed will either fail or will run with
>> the most-recently-installed glxtrace.so (rather than the compiled
>> glxtrace.so). I think Zack mentioned earlier that he didn't want to
>> break that use case.
>
> Sorry. I really misread the patch. It looks like you actually fix this
> case. I'm curious that you use a compiled-in constant string for the
> build directory rather than calling os::getProcessName(). It seems the
> latter would be more robust, (though only relevant in possibly rare
> circumstances).

It was how it was being done before (just renamed the define and made
available to all source code, instead of just the gui subdir).Yes, I
agree we should try using relative paths when possible. os:Path is
missing a few methods to make that easy, and it's not urgent.

>> The bug I mention above is in code that will be shared here, I suppose,
>> so is probably easy for me to fix then.
>
> Sharing the code with the GUI isn't easy since the GUI is already using
> some much QT-provided functionality in this code, (QString, QFileInfo,
> etc.). So for now I'm not changing that code and not sharing. Let me
> know what you'd like, (you can wait to see the patches if you'd like).

It's fine if you leave Qt GUI as-is for now. It's probably better to
leave that later. Please just keep in mind the GUI needs as you go
along, so that it can later be slotted into the GUI without much
rewrite.