[Beignet] [PATCH] Start looking for LLVM from highest version down

Zhigang Gong zhigang.gong at linux.intel.com
Wed Dec 4 03:02:46 PST 2013


Simon,

Currently, the most stable version is llvm-3.3 and then llvm-3.2.
Although the clang 3.4 fixes one know vector related bug, but it
seems that it bring some severer regressions as below:
http://llvm.org/bugs/show_bug.cgi?id=18119
http://llvm.org/bugs/show_bug.cgi?id=18120

We hope they can be fixed before the final release version. Before that,
we should prefer llvm/clang 3.3 here.

On Mon, Dec 02, 2013 at 02:27:46PM +0100, Simon Richter wrote:
> When different LLVM versions are installed, look for 3.5, 3.4 and 3.3 in
> order, then try the system default.
> 
> As configuring for 3.1 and 3.2 gives an error now, drop these versions from
> the search.
> 
> Signed-off-by: Simon Richter <Simon.Richter at hogyros.de>
> ---
>  CMake/FindLLVM.cmake |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/CMake/FindLLVM.cmake b/CMake/FindLLVM.cmake
> index 339a099..84a3397 100644
> --- a/CMake/FindLLVM.cmake
> +++ b/CMake/FindLLVM.cmake
> @@ -7,9 +7,9 @@
>  # LLVM_MODULE_LIBS - list of llvm libs for working with modules.
>  # LLVM_FOUND       - True if llvm found.
>  if (LLVM_INSTALL_DIR)
> -  find_program(LLVM_CONFIG_EXECUTABLE NAMES llvm-config-32 llvm-config-3.2 llvm-config-31 llvm-config-3.1 llvm-config-3.4 llvm-config DOC "llvm-config executable" PATHS ${LLVM_INSTALL_DIR} NO_DEFAULT_PATH)
> -else (LLVM_INSTALL_DIR)
> -  find_program(LLVM_CONFIG_EXECUTABLE NAMES llvm-config-32 llvm-config-3.2 llvm-config-31 llvm-config-3.1 llvm-config-3.4 llvm-config DOC "llvm-config executable")
> +  find_program(LLVM_CONFIG_EXECUTABLE NAMES llvm-config-35 llvm-config-3.5 llvm-config-34 llvm-config-3.4 llvm-config-33 llvm-config-3.3 llvm-config DOC "llvm-config executable" PATHS ${LLVM_INSTALL_DIR} NO_DEFAULT_PATH)
> +else (LLVM_INSTALL_DIR)                                                    
> +  find_program(LLVM_CONFIG_EXECUTABLE NAMES llvm-config-35 llvm-config-3.5 llvm-config-34 llvm-config-3.4 llvm-config-33 llvm-config-3.3 llvm-config DOC "llvm-config executable")
>  endif (LLVM_INSTALL_DIR)
>  
>  if (LLVM_CONFIG_EXECUTABLE)
> -- 
> 1.7.10.4
> 
> _______________________________________________
> Beignet mailing list
> Beignet at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/beignet


More information about the Beignet mailing list