[compiz] Bug in otherScreenGrabExist?

David Reveman davidr at novell.com
Fri May 4 07:05:22 PDT 2007


On Fri, 2007-05-04 at 12:20 +0100, Mike Dransfield wrote:
> David Reveman wrote:
> > On Fri, 2007-05-04 at 00:49 +0100, Mike Dransfield wrote:
> >   
> >> I am fairly sure that this is just a bug in the codes logic, but
> >> I thought I should check first
> >>     
> >
> > hm, I think the code is currently doing the correct thing.
> >   
> 
> In that case I think this patch is more appropriate ;)
> 
> Do you think it is clear and correct?

Yes, that's how that function works so please add that comment if it
wasn't obvious. I assume that this part was just some local change that
really shouldn't be in the patch:

@@ -655,6 +655,7 @@ typedef Bool (*ImageToFileProc) (CompDisplay *display,
 #define NOTIFY_DELETE_MASK (1 << 1)
 #define NOTIFY_MOVE_MASK   (1 << 2)
 #define NOTIFY_MODIFY_MASK (1 << 3)
+#define NOTIFY_OPEN_MASK   (1 << 4)
 
 typedef void (*FileWatchCallBackProc) (const char *name,
 				       void	  *closure);
 
- David



More information about the compiz mailing list