[compiz] removing string restrictions

David Reveman davidr at novell.com
Mon May 14 11:00:10 PDT 2007


On Fri, 2007-05-11 at 18:53 +0200, Dennis Kasprzyk wrote:
> Am Freitag, 11. Mai 2007 17:15 schrieb David Reveman:
> > On Fri, 2007-05-11 at 11:45 +0200, Dennis Kasprzyk wrote:
> > > Am Donnerstag, 10. Mai 2007 21:24 schrieb David Reveman:
> > > > We've previously discussed if we should add some sort of selection
> > > > option type and not use string options and string restrictions for that
> > > > purpose.
> > > >
> > > > I don't think we need a new option type for this. The integer type
> > > > should do just fine. The attached patch changes the blur plugin's
> > > > filter option from string to integer type and adds the relevant
> > > > metadata. I suggest that we change all existing options that use string
> > > > restrictions in a similar way and remove the string restrictions
> > > > completely.
> > > >
> > > > Questions? Does it sounds OK?
> > > >
> > > > - David
> > >
> > > I like the idea, but I would prefer a different XML style.
> > > <desc>
> > > 	<_name value="1">Foo</_name>
> > > 	<_name value="2">Foo2</_name>
> > > 	<_name value="3">Foo3</_name>
> > > </desc>
> >
> > I wanted the <desc> tag to look the same for every option type and not
> > all option type values can be represented as strings. e.g. actions. All
> > option values in the meta data are currently within tags, hence it makes
> > sense to keep these values within tags as well.
> >
> > - David
> 
> Maybe you should provide some kind of final layout description (also for the 
> dependency rules), so that we can start to implement it. Getting everything 
> together from different mails is painfull. 

The dependency rules are unrelated to this and should be implemented
independently. I don't see any reason for merging the changes or the
discussions.

This string restriction change is easy as it can be done incrementally
once we've agreed on what XML style to use.

Someone could maintain a .dtd with all standard tags but plugins and
configuration tools are always allowed to extend it in whatever way they
want.

- David



More information about the compiz mailing list