[PATCH v6 4/5] drm/tidss: New driver for TI Keystone platform Display SubSystem

[Jyri Sarha]

On 15/01/2020 16:43, Sam Ravnborg wrote:
> Hi Jyri.
> 
>>>>
>>> ...
>>>> v6: - Check CTM and gamma support from dispc_features when creating crtc
>>>>     - Implement CTM support for k2g and fix k3 CTM implementation
>>>>     - Remove gamma property persistence and always write color properties
>>>>       in a new modeset
>>>
>>> I applied this, just to throw this throgh my build setup.
>>>
>>> checkpatch reported:
>>> total: 0 errors, 45 warnings, 46 checks, 4920 lines checked
>>>
>>> - space after cast
>>> - CamelCase
>>> - Macro argument
>>> - length warnings
>>> - alignment
>>>
>>> I would ignore the line length warnings for the coefficients, but fix the
>>> rest.
>>>
>>
>> You are using --subjective, or are there new warnings turned on since I
>> rebased?
> This was the warnigns that appearted when I did
> cat patches | dim apply
> 
> So the defaults in dim was used - which is:
> -q --emacs --strict --show-types
> 

Oh, I didn't know that dim uses --strict (= subjective). I have used dim
but never for anything this big and all those smaller patches have been
"strict"-clean, since I have not seen any warnings.

Well, I'll bite the bullet then, and start mangling the code to the
"strict" format.

Thanks,
Jyri

> As dim is the tool used when applying patches to drm-misc-next then
> whoever ends up applying the patches will see the same warnigns from
> checkpatch.
> 
> You can find more info on dim here:
> https://drm.pages.freedesktop.org/maintainer-tools/dim.html
> 
> As maintainer of this driver you will need to learn the basics.
> 
> My dim vocabulary are:
> dim apply
> dim fixes
> dim push
> dim update-branches
> dim checkpatch
> 
> dim can do much more, but this is the ones that I use most.
> In your case you would like to use "dim checkpatch HEAD~5"
> 
> 	Sam
> 


-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki