[PATCH v6 4/5] drm/tidss: New driver for TI Keystone platform Display SubSystem

Sam Ravnborg sam at ravnborg.org
Wed Jan 15 17:13:58 UTC 2020


Hi Jyri.

> Well, I'll bite the bullet then, and start mangling the code to the
> "strict" format.

While touching the code please consider moving all logging
over to the new drm_{err,warn,info,dbg} functions.
They give the nice "[drm]" marker.
And they are a tad shorter as you do not have to dereference ddev->dev
everywhere.
And you then also gain support for controlling logging using
drm.debug=0xxxx, os sysfs too.

See drm_print.h in latest drm_misc_next

With or without this change you can add my:
Acked-by: Sam Ravnborg <sam at ravnborg.org>

	Sam


More information about the dri-devel mailing list