[Glamor] [PATCH 3/4] First attempt to make libglamor.so shared versioned library

Michel Dänzer michel at daenzer.net
Wed Mar 13 09:23:19 PDT 2013


On Mit, 2013-03-13 at 17:06 +0100, Armin K wrote: 
> * As recommended by Michael in this thread reply:

Michel

Also, the asterisks look weird in the long description.


> diff --git a/src/Makefile.am b/src/Makefile.am
> index 0879287..5121ce4 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -10,14 +10,12 @@ else
>  libglamor_la_LIBADD = $(GL_LIBS)
>  endif
>  
> -instdir = $(moduledir)

This will cause the glamoregl module to be installed in the wrong place,
won't it? Can you make this line apply only to libglamoregl instead?


> -libglamor_la_LDFLAGS = -avoid-version
> +libglamor_la_LDFLAGS = -version-info 1:0:1

Not sure there's much point to this at this point, but I guess it
doesn't hurt...


The rest of this patch and the other patches look good to me, but I'm
not really an autotools expert.


-- 
Earthling Michel Dänzer           |                   http://www.amd.com
Libre software enthusiast         |          Debian, X and DRI developer


More information about the Glamor mailing list