[Glamor] [PATCH 3/4] First attempt to make libglamor.so shared versioned library

[Armin K.]

On 03/13/2013 05:23 PM, Michel Dänzer wrote:
> On Mit, 2013-03-13 at 17:06 +0100, Armin K wrote:
>> * As recommended by Michael in this thread reply:
>
> Michel
>
> Also, the asterisks look weird in the long description.
>
>

Hm, sorry. I am new to this. I need to get used to git. I'll resend 
patches with correct descriptions.

I am sorry for mispelling Your name.

>> diff --git a/src/Makefile.am b/src/Makefile.am
>> index 0879287..5121ce4 100644
>> --- a/src/Makefile.am
>> +++ b/src/Makefile.am
>> @@ -10,14 +10,12 @@ else
>>   libglamor_la_LIBADD = $(GL_LIBS)
>>   endif
>>
>> -instdir = $(moduledir)
>
> This will cause the glamoregl module to be installed in the wrong place,
> won't it? Can you make this line apply only to libglamoregl instead?
>
>

No, there is module_LTLIBRARIES = $(LIBGLAMOREGL) which means it will 
install libglamoregl to moduledir.

>> -libglamor_la_LDFLAGS = -avoid-version
>> +libglamor_la_LDFLAGS = -version-info 1:0:1
>
> Not sure there's much point to this at this point, but I guess it
> doesn't hurt...
>

This is what gets installed with ./configure --prefix=/usr

/usr/lib/libglamor.la
/usr/lib/libglamor.so
/usr/lib/libglamor.so.0
/usr/lib/libglamor.so.0.1.0
/usr/lib/pkgconfig/glamor-egl.pc
/usr/lib/pkgconfig/glamor.pc
/usr/lib/xorg/modules/libglamoregl.la
/usr/lib/xorg/modules/libglamoregl.so
/usr/share/X11/xorg.conf.d/glamor.conf

Without this line, there wouldn't be any

/usr/lib/libglamor.so.0
/usr/lib/libglamor.so.0.1.0

but only

/usr/lib/libglamor.so

And some distros don't like having to link their stuff to unversioned 
libraries. We might want this to be 0.0.0 though. I'll correct that.

>
> The rest of this patch and the other patches look good to me, but I'm
> not really an autotools expert.
>
>